Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make iptables Error judge with protocal to adapt both ipv4 and ipv6 #57

Merged
merged 2 commits into from
Apr 26, 2019

Conversation

mars1024
Copy link
Contributor

@mars1024 mars1024 commented Apr 26, 2019

When judging iptables Error, some fixed strings are used, like "iptables: No chain/target/match by that name.\n", but when we use ip6tables in ipv6 protocal, the same return message is "ip6tables: No chain/target/match by that name.\n", these two strings mismatch. And this raises some troubles like CI broken.

So I think we can add protocal to Error struct and make judgements with protocal together.

@mars1024
Copy link
Contributor Author

@squeed PTAL, thanks ~

@squeed
Copy link
Collaborator

squeed commented Apr 26, 2019

That was quick :-)

@mars1024
Copy link
Contributor Author

That was quick :-)

Call me The Flash :)

@squeed
Copy link
Collaborator

squeed commented Apr 26, 2019

LGTM.

@squeed squeed merged commit 78b5fff into coreos:master Apr 26, 2019
@mars1024 mars1024 deleted the bugfix/isnotexist_ip6tables branch April 26, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants